diff --git a/addons/default/visiosoft/advs-module/resources/lang/en/message.php b/addons/default/visiosoft/advs-module/resources/lang/en/message.php index 8fb05b55f..2ee555855 100644 --- a/addons/default/visiosoft/advs-module/resources/lang/en/message.php +++ b/addons/default/visiosoft/advs-module/resources/lang/en/message.php @@ -26,4 +26,5 @@ return [ 'replicated_success' => 'The ad has been replicated successfully!', 'ad_doesnt_exist' => "This ad doesn't exist!", 'select_location_error' => "Please select a location on the map!", + 'this_ad_is_not_valid_anymore' => "This ad is not valid anymore!", ]; diff --git a/addons/default/visiosoft/advs-module/src/Adv/AdvPresenter.php b/addons/default/visiosoft/advs-module/src/Adv/AdvPresenter.php index 38b99bb8f..1f0aaa106 100644 --- a/addons/default/visiosoft/advs-module/src/Adv/AdvPresenter.php +++ b/addons/default/visiosoft/advs-module/src/Adv/AdvPresenter.php @@ -62,7 +62,7 @@ class AdvPresenter extends EntryPresenter public function isCorporate() { $user_id = $this->getObject()->created_by; - if ($user_id && $user_id->register_type != null) { + if ($user_id->register_type != null) { return $user_id->register_type; } else { return 1; diff --git a/addons/default/visiosoft/advs-module/src/Http/Controller/advsController.php b/addons/default/visiosoft/advs-module/src/Http/Controller/advsController.php index f46783a6e..288349272 100644 --- a/addons/default/visiosoft/advs-module/src/Http/Controller/advsController.php +++ b/addons/default/visiosoft/advs-module/src/Http/Controller/advsController.php @@ -485,6 +485,11 @@ class AdvsController extends PublicController $adv = $this->adv_repository->getListItemAdv($id); if ($adv && (!$adv->expired() || $adv->created_by_id === \auth()->id())) { + // Check if created by exists + if (!$adv->created_by) { + $this->messages->error('visiosoft.module.advs::message.this_ad_is_not_valid_anymore'); + return $this->redirect->route('visiosoft.module.advs::list'); + } if ($this->adv_model->is_enabled('complaints')) { $complaints = ComplaintsComplainTypesEntryModel::all();